search

MozillaFoundation / foundation.mozilla.org

Mozilla Foundation website
https://foundation.mozilla.org
Mozilla Public License 2.0
388 stars 153 forks source link

Blog: add comments to post detail page #3589

Closed kristinashu closed 4 years ago

kristinashu commented 5 years ago

From epic ticket https://github.com/mozilla/foundation.mozilla.org/issues/2797

Add comment feature to individual blog post pages similar to PNI and IHR.

By default comments feature should be off but staff should be able to turn them on for specific posts.

Jen C and I can moderate.

@alanmoo should we just Coral Talk for this?

alanmoo commented 5 years ago

Yup, absolutely.

kristinashu commented 5 years ago

This is the P1 from the *Privacy Included work https://github.com/mozilla/foundation.mozilla.org/issues/3801. Deadline is Nov 12.

alanmoo commented 5 years ago

@cadecairos Any reason we shouldn't use the same Talk instance as PNI for blogs?

If so, this should be a matter of copying the code from PNI into the blog template. @youriwims we'll need to get you access to whatever instance of talk we're using.

From a functional standpoint, unless I'm missing something in the Talk admin, we'll have to add a flag to the settings of the Blog page model to enable comments, and then conditionally render the div that Coral uses based on a check for that boolean in the template.

cadecairos commented 5 years ago

Any reason we shouldn't use the same Talk instance as PNI for blogs?

None that I can think of. We should probably look into upgrading that instance.

alanmoo commented 5 years ago

And maybe getting it a proper sub domain?

cadecairos commented 5 years ago

got one in mind?

alanmoo commented 5 years ago

comments.mozilla.org? (Or comments.mozillafoundation.org)

Kristina, any opinion on that? It really only shows up in the url bar when logging in to comment.

-Alan Mooiman, Mozilla Foundation Engineering Manager Eastern Daylight Time (USA) UTC-4 On Oct 25, 2019, 9:37 PM +0100, Christopher DeCairos notifications@github.com, wrote:

got one in mind? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

kristinashu commented 5 years ago

No real opinion but maybe comments.mozillafoundation.org would be clearer?

alanmoo commented 5 years ago

Great. I'll file a separate devops ticket. @youriwims, please work on this when you're back in Canada; Getting the initial implementation working shouldn't take more than a day.