Closed benhohner closed 3 years ago
Callpower code in our old donate repo: https://github.com/mozilla/advocacy.mozilla.org/blob/master/routes/call.js
@benhohner to add docs from call with Josh
Notes from meeting with Josh:
Looking at https://github.com/OpenSourceActivismTech/call-power this appears to be a "deployable by us" server that we need to provision on Heroku, rather than an already-established third party API that we make API calls to. Is that the actual intention here? Because that opens up a whole can of security concerns.
We're just looking to call their RESTful API to submit a call action to it when someone fills in their phone number. We definitely don't need to host anything!
On Thu, Sep 9, 2021 at 7:48 PM Pomax @.***> wrote:
Looking at https://github.com/OpenSourceActivismTech/call-power this appears to be a "deployable by us" server, is that the actual intention here?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/foundation.mozilla.org/issues/7284#issuecomment-916492035, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALFHMM76VWIF46XQ7RIGNLUBE2VBANCNFSM5DCI63FQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
@ben I cannot find any documentation on that RESTful API or which endpoint(s) to use, could you (or someone else) either drop that information into this issue, or communicate that to me through non-public channels?
While it's easy to implement this as extension to CTA, having existing campaigns allow for "any extension of a CTA" is proving fairly complicated in wagtail (as in, not sure if we can do this) so I'm asking for help on the wagtail slack, but if this isn't possible we may need to rethink how we want to do this.
Hey @kristinashu we're almost done integrating callpower, wondering if you could assign to a designer to review the UX/UI with Pomax?
Hey, you can put me down for now.
bumping the estimate up for this one, because our old React code is properly old at this point, and quite convoluted for current React devs, and just writing some clear, concise, modern plain JS to work with the django-template's HTML directly is going to be much, much more maintainable going forward.
Working on this, some questions:
@Pomax
Hey, I have no idea what this looks like or what the flow is. Do we know what the form fields are and what the flow is? Are there real examples of Call Power being used somewhere (not on our site but somewhere on the web)? I'm curious how they handle locations.
Not sure, although in terms of what it looks like "right now" I now have a PR up with a review app over on https://github.com/mozilla/foundation.mozilla.org/pull/7577 that has a live demo page up on https://foundation-s-genericise-ftncey.mofostaging.net/en/campaigns/initial-test-bannered-campaign-with-fixed-title/
Note that the TOGGLE
button is a workflow-faking-button that switches the CTA's content, as if you successfully presse the "make the call" button. Mostly as a convenient way for us to see what we're working on without having to constantly make actual calls to a test campaign.
@benhohner
I managed to run the old advocay site, where we presented it a very cyan way:
Notes from our meeting are here.
Here are some quick mock-up and I've shared it in slack for feedback from Kaili. Note: I'm assuming the snippet will be available on both Banner and Campaign page types.
Kaili said the mock-up looks good so this should now be unblocked.
Here are some quick mock-up
Perfect, I will update the CTA template and model accordingly.
I'm assuming the snippet will be available on both Banner and Campaign page types.
Yep!
@kristina it looks like the social share butttons don't cover the full column width, should they? Or should they be a smaller total width?
From the comp:
Using the same stacked layout component that is used for petitions:
Oh they should be full column, or whatever is already in use. Thanks for checking!
For the "error" case, what do we want to show the user? I'm currently using "Something went wrong..." as heading and then the debug error, but that's not super great =D
The old Advocacy code uses the following possible body texts
"we don't know what's wrong":
We’re sorry, we seem to be having some trouble.
Please try again later.
Someone filled in a bad phone number (in this case I assume we want some kind of "back" button so the user doesn't have to reload the page):
We can’t call that number.
Someone's calling so much that they're getting rate-limited:
Thanks for your calls! You’ve reached the hourly limit. Please try again in an hour.
The old Advocacy ones sound good.
I would just edit:
We can’t call that number.
to
We're sorry, we can’t call that number. Please double check the number or try a different one.
And the other ones look good as is.
Can do - do we want to offer users a "back" button, or do we want to automatically send them back to the form but with the description updated?
Please send them back automatically with the error text.
https://github.com/mozilla/foundation.mozilla.org/pull/7577 should be ready for review.
We need to integrated the Callpower call activism tool into Fo'Mo. It allows you to enter your phone number and receive a call that connects you with one of more of your local representatives. The purpose of this is for the new head of the FCC election. We'd like to reach out to people to get them to express support for a progressive ex-mozillian candidate.
old code: