MozillaFoundation / foundation.mozilla.org

Mozilla Foundation website
https://foundation.mozilla.org
Mozilla Public License 2.0
385 stars 153 forks source link

Implement section divider ui alignment #822

Closed kristinashu closed 6 years ago

kristinashu commented 6 years ago

From alignment work in mozilla/network#582 and to align better with new brand, mozilla.org, Network site, and IRH sites.

Comp https://redpen.io/ygc29beb3e61e39afb

screen shot 2017-10-05 at 10 46 23 am

Update dashed divider to gradient + highlight text. Note that sometimes the divider is gradient + highlight text and sometimes it is only the highlight text (no gradient)(example).

Related to Pulse nav update https://github.com/mozilla/network-pulse/issues/731

cc @gvn

kristinashu commented 6 years ago

Sweet! Looks good except the dividers at top of the Landing page and also the Upcoming page look a little too close to the banner image.

Example: screen-shot-2017-10-17-at-8 40 56-am

Please increase the the gap from what I think is 30px to 50px.

Padding on all the other dividers (example: 'Network Leaders' and 'Get Involved' lower down on the Landing page) look good.

kristinashu commented 6 years ago

Sorry, one more thing... can you add the selected state? So if I'm on the projects page then "Projects" should be underlined (like the hover state). It seems to be there on narrow screens but not desktop.

gvn commented 6 years ago

Changes are up on staging to verify: https://network.mofostaging.net/

kristinashu commented 6 years ago

Awesome!