MozillaFoundation / foundation.mozilla.org

Mozilla Foundation website
https://foundation.mozilla.org
Mozilla Public License 2.0
389 stars 153 forks source link

Sign up snippets not syncing across translations #9642

Closed danielfmiranda closed 1 year ago

danielfmiranda commented 1 year ago

Describe the bug

Signup snippet changes on mozfest pages are not being synchronized, even after clicking "sync translations".

From Slack: The sign up snippet got removed from the updated English page https://www.mozillafestival.org/en/proposals/ in order to use the full width, but syncing translations doesn’t remove it from translated pages.

Steps to reproduce

  1. Visit https://www.mozillafestival.org/en/proposals/, note that there is no signup snippet set. Screenshot 2022-11-08 at 14-18-01 Submit your MozFest Session before December 16th

  2. Visit https://www.mozillafestival.org/fr/proposals/, and note that there is still a signup snippet on the page, even after clicking "sync translations". Screenshot 2022-11-08 at 14-18-24 Proposez votre session pour le MozFest avant le 16 décembre

Expected behavior

If a mozfest page removes/changes it's linked signup snippet, its localized versions should show the same change after clicking "sync translations".

tbrlpld commented 1 year ago

I think it would be good to describe the expected behaviour in a bit more detail. Are no changes carrying over?

danielfmiranda commented 1 year ago

Hi @cdanfon this is now on staging and ready to be tested!

Acceptance Criteria

Steps to test:

  1. Visit http://mozillafestival.mofostaging.net/en/proposals/ and note that there is no sign up snippet on the right side of the page.
  2. Visit http://mozillafestival.mofostaging.net/fr/proposals/ and note that it is the same (no signup snippet set)
  3. Edit the page in the CMS https://mozillafestival.mofostaging.net/cms/pages/421/edit/ and add a sign up snippet.
  4. Once finished editing, select "sync translated pages" in the CMS, and then "publish immediately". Screenshot 2022-11-17 at 15-43-26 Wagtail - Exploring Mozilla Festival Screenshot 2022-11-17 at 15-44-06 Wagtail - Update existing translations Call For Proposals
  5. Visit http://mozillafestival.mofostaging.net/en/proposals/ again, and note the new sign up snippet on the right side
  6. Visit the page in any other language, for example http://mozillafestival.mofostaging.net/fr/proposals/, and there should be a sign up snippet as well.

Note: If a localized version of the sign up snippet does not exist, it will render the English version

Thanks in advance!

danielfmiranda commented 1 year ago

Just tested this out myself and seems to be working as expected 👍

cdanfon commented 1 year ago

Looking good, nice one @danielfmiranda !