Open cecilebertin opened 6 years ago
In Introduction, buttons before the footer: 2018 Spotlights => Enjeux 2018 (French)
In Introduction, 2018 Spotlights page: Type next to Issue in frame: Spotlight => Enjeu (French)
Navigation labels on arrows and "x" when navigating articles in Issues:
Go back to issue => Revenir au thème (French)
Next article: EnglishTitle => Prochain article : FrenchTitle (French)
Previous article: EnglishTitle => Article précédent : FrenchTitle (French)
You have not written any comments => Vous n’avez pas encore écrit de commentaires (French)
A history of your comments will appear here => Un historique de vos commentaires apparaîtra ici (French)
Sign in to access Profile => Connectez-vous pour accéder au profil (French)
From the Profile Page you can see your comment history. => Depuis la page de profil vous pouvez consulter l’historique de vos commentaires.
Cecile, thanks so much! I corrected whatever I could. The comments section (profile etc.) changes the language with the browser language, unfortunately it doesn't change when you manually switch it. If you have your browser set to French, all will be translated. The Report will also switch to French automatically. README is a geeky joke and we decided to leave it the same in every languages without any translation. The Website header also stays in English as it's one file only. We translate the name of the report in the tagline on the homepage. There seems to be a problem with the search category tags though, I hope we can fix it in the next days. They show correctly on the issue pages, maybe it is a cache problem.
The comments section (profile etc.) changes the language with the browser language, unfortunately it doesn't change when you manually switch it. If you have your browser set to French, all will be translated.
My browsers are all set to French, but it is not translated
Try incognito window (cache again)
I tried and not everything is translated.
The italic text is by us and by design: We wanted to avoid very long text in 4 languages as this box appears across all languages with the same text - that is why it links to all languages versions. As for the other sentence, I would flag that to @losowsky as this seems like a bug in localization of the Talk plugin. Thanks, Cecile!
For the comment section, I also tried in Safari in a private window (and I emptied the cache) and nothing is translated (even the buttons). My Safari browser is also in French.
That's weird - all the buttons translate fine for me, just not the text in the comment space. Am looking into why.
---------------------------- Andrew Losowsky @losowsky https://twitter.com/losowsky The Coral Project http://coralproject.net
On Mon, Apr 9, 2018 at 6:26 PM, Cecile Bertin notifications@github.com wrote:
For the comment section, I also tried in Safari in a private window and nothing is translated (even the buttons). My Safari browser is also in French.
[image: capture d ecran 2018-04-09 a 15 21 58] https://user-images.githubusercontent.com/21285660/38526167-0f1d8a82-3c0a-11e8-8152-339c71b6d6b8.png [image: capture d ecran 2018-04-09 a 15 21 30] https://user-images.githubusercontent.com/21285660/38526165-0ef1a7b4-3c0a-11e8-8fed-36bf2ea81499.png
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MozillaFoundation/internet-health-report-2018-bugs/issues/55#issuecomment-379912926, or mute the thread https://github.com/notifications/unsubscribe-auth/AJjQI54T5YcuOOjXJ4e4Bqf12svSyigVks5tm-ACgaJpZM4TM9Tp .
Aha, found the issue - it's because our French file is missing translations! Do you have someone who can go through this and file a PR with the missing phrases throughout that file?
https://github.com/coralproject/talk/blob/master/locales/fr.yml
It's fine for Spanish and German (see below)
---------------------------- Andrew Losowsky @losowsky https://twitter.com/losowsky The Coral Project http://coralproject.net
On Mon, Apr 9, 2018 at 6:37 PM, Andrew Losowsky andrew@losowsky.com wrote:
That's weird - all the buttons translate fine for me, just not the text in the comment space. Am looking into why.
---------------------------- Andrew Losowsky @losowsky https://twitter.com/losowsky The Coral Project http://coralproject.net
On Mon, Apr 9, 2018 at 6:26 PM, Cecile Bertin notifications@github.com wrote:
For the comment section, I also tried in Safari in a private window and nothing is translated (even the buttons). My Safari browser is also in French.
[image: capture d ecran 2018-04-09 a 15 21 58] https://user-images.githubusercontent.com/21285660/38526167-0f1d8a82-3c0a-11e8-8152-339c71b6d6b8.png [image: capture d ecran 2018-04-09 a 15 21 30] https://user-images.githubusercontent.com/21285660/38526165-0ef1a7b4-3c0a-11e8-8fed-36bf2ea81499.png
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MozillaFoundation/internet-health-report-2018-bugs/issues/55#issuecomment-379912926, or mute the thread https://github.com/notifications/unsubscribe-auth/AJjQI54T5YcuOOjXJ4e4Bqf12svSyigVks5tm-ACgaJpZM4TM9Tp .
I can work on this, if that's ok.
yes please! Thanks Cecile.
---------------------------- Andrew Losowsky @losowsky https://twitter.com/losowsky The Coral Project http://coralproject.net
On Mon, Apr 9, 2018 at 8:20 PM, Cecile Bertin notifications@github.com wrote:
I can work on this, if that's ok.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MozillaFoundation/internet-health-report-2018-bugs/issues/55#issuecomment-379934290, or mute the thread https://github.com/notifications/unsubscribe-auth/AJjQI2YL7iQLLwwcWYwHlMrb_pO0gwBeks5tm_rLgaJpZM4TM9Tp .
I did added a PR with the missing strings and translations for the french file. See https://github.com/coralproject/talk/pull/1515
A pro translator should review my translations.
You are amazing, Cecile, merci!
Kasia, do you want to find a professional translator to review this first? (We don't have any contacts there, this is your call)
---------------------------- Andrew Losowsky @losowsky https://twitter.com/losowsky The Coral Project http://coralproject.net
On Tue, Apr 10, 2018 at 3:32 AM, Kasia notifications@github.com wrote:
You are amazing, Cecile, merci!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MozillaFoundation/internet-health-report-2018-bugs/issues/55#issuecomment-380003187, or mute the thread https://github.com/notifications/unsubscribe-auth/AJjQI1YoSxoZJdwxRau3jWTXZRMhPj8Sks5tnGANgaJpZM4TM9Tp .
Will this need to be deployed on the site? We can't deploy today. I don't have resources now to put a translator on it but if it updates automatically, I would go with Cecile's translations (better than English!).
Hey there, commenting here too — I took the opportunity to do a quick review, hope you don’t mind
Great! Thank you!
On Tue, Apr 10, 2018 at 17:46 Théo Chevalier notifications@github.com wrote:
Hey there, commenting here too — I took the opportunity to do a quick review, hope you don’t mind
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MozillaFoundation/internet-health-report-2018-bugs/issues/55#issuecomment-380149357, or mute the thread https://github.com/notifications/unsubscribe-auth/AVGppYiD1l44RR_abJi_lJJg-gmv2rnCks5tnNPLgaJpZM4TM9Tp .
-- Kasia Odrozek Project Coordinator, Internet Health Report| Mozilla Foundation
Cell: +49 176 47686588 | Twitter: @kaodro https://twitter.com/kaodro Currently in Berlin, Germany
Thanks Theo. Can you make the changes instead of writing them as comments? Then I can merge the changes in.
And yes, Kasia: once I do that, it'll need to be deployed by pulling the latest from Master.
Thanks @TheoChevalier for the review!!! Do you want me to make the changes in the PR, or are you already on it?
Well, thanks for the translations @cecilebertin! Feel free to go in and update the file, I won’t be able to do it for the next couple hours (meetings), but I can have a look after that if you want
Ok, I will do it right away then. Thank you!
Amazing, thank you! This is now the final piece for our next release, so let me know when it's ready and we'll push 4.3.1. Thank you!
---------------------------- Andrew Losowsky @losowsky https://twitter.com/losowsky The Coral Project http://coralproject.net
On Tue, Apr 10, 2018 at 12:14 PM, Cecile Bertin notifications@github.com wrote:
Ok, I will do it right away then. Thank you!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MozillaFoundation/internet-health-report-2018-bugs/issues/55#issuecomment-380159436, or mute the thread https://github.com/notifications/unsubscribe-auth/AJjQI4NehxFS1pwfo_GJAdvr627aHPVmks5tnNpVgaJpZM4TM9Tp .
Commit with fixes pushed to PR!
Merged! Thank you!
@cadecairos can we update Talk to show French translations in the Report?
@kaodro deployed
French Translations:
Comment section:
Comments button => Commentaires
See Mozilla Community Participation Guidelines [English | Español | Deutsch | Français]. Critiquez les idées, pas les personnes. Offensive comments will be removed. => Consulter les directives relatives à la participation communautaire de Mozilla [English | Español | Deutsch | Français]. Tout commentaire offensant sera retiré.
There are no comments yet, why don’t you write one? => Il n’y a aucun commentaire pour le moment. Soyez le premier à commenter !
Sign in to comment => Connectez-vous pour commenter
Search section:
Drop-down lists:
All issues => Tous les thèmes
All types => Toutes les catégories
Search field:
Keyword search => Recherche par mot-clé
Categories in result frames:
People => Personnes
Data => Données
Analysis => Analyse
Spotlight => Enjeu
Website Header:
Internet Health Report 2018 => Bulletin de santé d’Internet 2018
General (on several places on website):
README (navigation bar, footer, Introduction section, Introduction section: buttons at the bottom of the page) => LISEZMOI (not sure how this should be translated)
/cc @kaodro /cc @TheoChevalier