MozillaFoundation / mofo-lightsaber

Giving every mofo a lightsaber in 2015
1 stars 0 forks source link

Enable export to HTML #11

Closed OpenMatt closed 9 years ago

OpenMatt commented 9 years ago

This is extremely handy for easily turning etherpads into blog posts, etc.

JohnMcLear commented 9 years ago

It's enabled by default

OpenMatt commented 9 years ago

I tried it on pad.webmaker.org and couldn't get it to export actual HTML -- it just resulted in a blank export. Would test it but pad.webmaker.org is down right now.

JohnMcLear commented 9 years ago

https://beta.etherpad.org is a useful playground for life.

jdotpz commented 9 years ago

Perhaps we need to be on the develop branch for it. I'm going to roll a .deb for it today and get it over to etherpadorg as well as use it to install all sorts of properly on our demo instance.

jdotpz commented 9 years ago

Seems to be working on the new branch! htmlbaby

OpenMatt commented 9 years ago

just tried this and it doesn't seem to work

OpenMatt commented 9 years ago

I'm going to make this a P1 because, with the new formatting features, this could save program managers a lot of time. It means we can turn an etherpad agenda into a blog post much more quickly, preserving formatting, etc.

JohnMcLear commented 9 years ago

I just tested it and it's working for me...

What problem are you having @OpenMatt ?

https://pad.webmaker.org/p/FgOLLbBJuS/export/html

jdotpz commented 9 years ago

Yup, it works under /p but not under the reverse proxy. I'll double check my reverse proxying.

jdotpz commented 9 years ago

Hmmm...this is my reverse proxy, but i'm not so sure what I'm supposed to add there? apologies! http://pastebin.mozilla.org/8525136

JohnMcLear commented 9 years ago

@jdotpz I don't know what URL endpoints you expect to work so I'm not sure how useful I am? Like how are you getting the wrong URLs for exporting? They should be like.. https://pad.webmaker.org/p/FgOLLbBJuS/export/html

If you are doing..

https://pad.webmaker.org/FgOLLbBJuS/export/html

Then you will need to rewrite that to

https://pad.webmaker.org/p/FgOLLbBJuS/export/html

I haven't written nginx in a while but I guess it would be something similar to

rewrite ^(.*)/export/(.*) /p/$1/export/$2 break;

Prior to the rewrite /(.*) /p/$1; rule..

Again disclaimer I haven't tested this that's just what I assume is needed from looking at your nginx config..

jdotpz commented 9 years ago

Nah, afraid that didn't do the trick. I suck at rewrites, and haven't had time to mess with it after testing.

JohnMcLear commented 9 years ago

Weirdly I tested this like 5 mins ago and your rule is working..

JohnMcLear commented 9 years ago

https://pad.webmaker.org/FgOLLbBJuS/export/html is an active endpoint now... What am I missing?

jdotpz commented 9 years ago

It seems the plugin itself is pointing to a null link:

screen shot 2015-02-10 at 2 11 25 pm

jdotpz commented 9 years ago

eth-null

JohnMcLear commented 9 years ago

How do you see that? under export on the pad? ----- Reply message ----- From: "JP Schneider" notifications@github.com To: "MozillaFoundation/mofo-lightsaber" mofo-lightsaber@noreply.github.com Cc: "John McLear" John@mclear.co Subject: [mofo-lightsaber] Enable export to HTML (#11) Date: Tue, Feb 10, 2015 20:11

It seems the plugin itself is pointing to a null link:

[screen shot 2015-02-10 at 2 11 25 pm]https://cloud.githubusercontent.com/assets/1373628/6135499/c6aba66c-b12e-11e4-8906-36626926c5de.JPG

— Reply to this email directly or view it on GitHubhttps://github.com/MozillaFoundation/mofo-lightsaber/issues/11#issuecomment-73774435.

jdotpz commented 9 years ago

(Note the url of the links I'm highlighting in my lower left corner of the browser)

jdotpz commented 9 years ago

Correct, under export as shown in that gif.

JohnMcLear commented 9 years ago

Aha I see this now..

JohnMcLear commented 9 years ago

I put a fix into develop, give it a go

https://github.com/ether/etherpad-lite/pull/2515

OpenMatt commented 9 years ago

Thanks @JohnMcLear !

OpenMatt commented 9 years ago

done! this now works.