search

MozillaFoundation / mofo-style

JavaScript Style Guide
15 stars 6 forks source link

Switch to stylelint ? #46

Open gvn opened 8 years ago

gvn commented 8 years ago

sass-lint is proving very buggy at this point, so I'm thinking we should investigate stylelint as an alternative.

My hope is that we can keep our current rules the same to ease the transition...

CC: @vazquez @alanmoo

vazquez commented 8 years ago

I would like for us to switch to stylelint, sass-lint is proving too buggy for us to write good CSS. The output of stylelint also seems to be a bit more readable, which is always good:

example

alanmoo commented 8 years ago

I noticed the Science repo is using stylelint and extending a default configuration. I'm playing around with it (due to my editor's stylelint plugin giving me warnings). It seems useful, though I'm not sure I love everything about the newest stylelint-config-standard. I do, however, like the idea of just using a standard and not having to put more effort in to adjusting it to our idiosyncrasies 😁

alanmoo commented 8 years ago

(Specifically an empty line being required as demonstrated below is a bit odd, but I can deal)

.container-dynamic {
  @include make-container();

  max-width: $bp-xl;
}