search

MozillaFoundation / plan

What the MoFo production teams are working on
https://build.mozillafoundation.org
18 stars 4 forks source link

Stop removing P1 & P2 labels when tickets close #743

Closed cassiemc closed 8 years ago

cassiemc commented 8 years ago

This behaviour seems to be automated from build.mozillafoundation.org, we suspect. I believe @simonwex was going to look into it.

cassiemc commented 8 years ago

Guessing this is small. @simonwex can I assign to you?

edrushka commented 8 years ago

I'm beginning to think it's not automated. Instead, I suspect @OpenMatt loves GitHub so much that he's watching it ALL THE TIME. Always Be Closing (tickets).

cassiemc commented 8 years ago

Lol. Since @simonwex is overwhelmed this heartbeat, wondering if he can delegate or maybe @davidascher can help. Of course not a huge priority, but it's annoying.

davidascher commented 8 years ago

I don't recall writing code to remove tickets, but I may have. @cadecairos has looked at this codebase more recently than I have. It's possible his latest code changes will break this feature anyway ;-).

On Fri, Feb 26, 2016 at 10:19 AM Cassie McDaniel notifications@github.com wrote:

Lol. Since @simonwex https://github.com/simonwex is overwhelmed this heartbeat, wondering if he can delegate or maybe @davidascher https://github.com/davidascher can help. Of course not a huge priority, but it's annoying.

— Reply to this email directly or view it on GitHub https://github.com/MozillaFoundation/plan/issues/743#issuecomment-189409084 .

OpenMatt commented 8 years ago

:) its not me!

davidascher commented 8 years ago

BTW: it's not matt ;-) If you look at a ticket, it seems to happen automatically and the person closing the ticket is blamed, e.g.:

[image: Screenshot 2016-02-26 10.44.09.png]

davidascher commented 8 years ago

@simonwex I should probably talk to @cade about the code both for book. and for plzkthx, which is likely to blame (and obsolete I think).

On Fri, Feb 26, 2016 at 10:45 AM David Ascher da@mozillafoundation.org wrote:

BTW: it's not matt ;-) If you look at a ticket, it seems to happen automatically and the person closing the ticket is blamed, e.g.:

[image: Screenshot 2016-02-26 10.44.09.png]

cadecairos commented 8 years ago

@davidascher we probably shouldn't pull in @cade on this one!

I'm pretty sure I took out all the code in build that modifies Github issues.

davidascher commented 8 years ago

We should review the webhooks on https://github.com/MozillaFoundation/plan/settings/hooks

My guess is we need to remove three of them.

On Fri, Feb 26, 2016 at 10:56 AM Christopher De Cairos < notifications@github.com> wrote:

@davidascher https://github.com/davidascher we probably shouldn't pull in @cade https://github.com/cade on this one!

I'm pretty sure I took out all the code in build that modifies Github issues.

— Reply to this email directly or view it on GitHub https://github.com/MozillaFoundation/plan/issues/743#issuecomment-189423238 .

cade commented 8 years ago

we probably shouldn't pull in @cade on this one!

player3

davidascher commented 8 years ago

Apologies @cade. Feel free to unsubscribe!

simonwex commented 8 years ago

Fixed this! – It was a hook with waffle.