Closed bhearsum closed 7 months ago
Thanks! We don't currently have an iOS dev to work on this, but we may soon, in which case I'll get them to look at your patch. And I'll try to raise the question with the glean experts.
Hello,
Thanks for the issue submission @bhearsum
The problem was related to the folder structure of the application, it must be fixed right now
When the application is built and compiles sources, the last step of the build is running the script
in the iOS project we are running a sdk_generator.sh
shell script, which reads the yaml files and generates the Generated
folder inside of this folder, generates Metrics.swift file which is generated by Glean
sdk with reading yaml file for configuration, somehow. in the iOS project, there's a GleanManager.swift file that handles all of the pings. This file contains a bunch of Glean
Pings-related codes
Previous developers put Generated/*
folder inside to .gitignore file, so there was no Generated folder inside the code when you downloaded it, i removed this usage, because in your case, GleanManager.swift
file try to reach some Glean Pings
which is not generated yet.
The old scenario was like this:
Generated/
folderGenerated/
folder into the Project structureGlean
Current scenario:
yaml
file, or if your telemetry data changes, change the yaml, build the app, and replace the current Generated/ folder with the newly generated Generated/
folder by Glean
sdk
There are at least two issues here: 1) The one noted in the README - where you have to comment out functions in the Glean code. I don't know what to do about this one. 2) The included project file includes references to
Generated
files that do not exist. These should either not be present in the project file that's checked in, or the generated files should be checked in.This patch to the project file is one way to fix the second issue: