search

MozillaIndia / leaderchalk

Leaderchalk is what writes on Leaderboard
Mozilla Public License 2.0
5 stars 24 forks source link

Resolved Fixed or Resolved Verfied? #22

Closed MrDHat closed 10 years ago

MrDHat commented 10 years ago

We use resolved verified instead of resolved fixed. Any reason for not using fixed?

ngsankha commented 10 years ago

No, the current code is correct. The final status of a bug can end up as RESOLVED FIXED or VERIFIED FIXED. Here {RESOLVED, VERIFIED} are the status of the bug hence it is kept in one array and FIXED is the resolution of the bug, so it is kept in another array.

MrDHat commented 10 years ago

I am not sure if I am getting this right - so, resolved, fixed as well as resolved, verified should appear in the solved bugs list, right?

ngsankha commented 10 years ago

No, RESOLVED FIXED and VERIFIED FIXED bugs should appear.

MrDHat commented 10 years ago

Oh yeah, sorry made a typo. In my case one bug is RESOLVED FIXED and one of them is VERIFIED FIXED But the leaderboard shows only 1 solved bug.

ngsankha commented 10 years ago

Ahh, I think this is because your case is a false postive for the filtering we had to implement for a few people. So the current code counts bugs as fixed if only you have a patch uploaded with with r+ marked. So as I see it bug 883886 has a patch but it doesn't have any r+ marked, so it is not being counted.