Clean indentation setup styleguide 173

[In4No]

Fixes #[173]

Changes: Cleaned up indentation and added eslint

Screenshots for the change: No screenshots as this does not affect UI

Before:

After:

[asdofindia]

I'm sorry I merged some other PRs making this conflict. Could you rebase and do this again, please?

[Amorpheuz]

I wouldn't disable all these rules, in my opinion, we should be fixing them instead of disabling them outright without a specific reason. In unique cases, we can disable them on a line by line or block by block. I feel these should be enabled:

• react/jsx-curly-brace-presence
• react/destructuring-assignment
• react/jsx-one-expression-per-line
• react/prop-types
• react/no-access-state-in-setstate
• no-unused-expressions
• semi should be always with omitLastInOneLineBlock set to true

Will have to checkup a bit more on:

• react/jsx-filename-extension
• jsx-a11y/no-static-element-interactions

Looks like an accessibility requirement which would be nice to have

• jsx-a11y/click-events-have-key-events

Would love to see comments from maintainers regarding the same! Can find more info on the same at:

• eslint rules
• eslint-plugin-react rules
• eslint-plugin-jsx-a11y rules

[In4No]

I wouldn't disable all these rules, in my opinion, we should be fixing them instead of disabling them outright without a specific reason. In unique cases, we can disable them on a line by line or block by block. I feel these should be enabled:

I disabled the rules so that, we can have separate PRs enabling one rule at a time. Did not intend to keep them permanently disabled.

[asdofindia]

Closing this as this has become stale now. Thanks for the work. Would you like to create a fresh PR?