search

MozillaItalia / MozItaReBot

riscrittura del bot di Mozilla Italia
6 stars 2 forks source link

[FEAT] Dockerfile to the project #28

Closed rivo2302 closed 2 years ago

rivo2302 commented 2 years ago
dag7dev commented 2 years ago

Thanks for your contribution! Could you please think about running the tests included in the tests folder?

Also, did you tested the machine?

rivo2302 commented 2 years ago

this doesn't sound like a breaking change, why did you moved row 105 to row 112?

@dag7dev You are right I have revert the commit for this

rivo2302 commented 2 years ago

Ye

Thanks for your contribution! Could you please think about running the tests included in the tests folder?

Also, did you tested the machine?

@dag7dev Yes, I thought about it. But I haven't had time to finish it yet. I'll work on it again as soon as I'm available.

Can you accept my PR?

Trafitto commented 2 years ago

Currently there is no need for Docker, we thank you for your contribution but I think the pr should be rejected.

There are other issues currently with more priority to do, if you need clarification do not hesitate to ask