search

MozillaKerala / Card-Generator

Visiting card generator for the Mozilla community
http://cards.mozillakerala.org
MIT License
42 stars 45 forks source link

Font Changes #11

Closed shinenelson closed 9 years ago

shinenelson commented 9 years ago

Change the fonts of the Reps and FSA cards to Open Sans. The font of mozilla in Reps card to Meta Bold. Font of Firefox in FSA card to Fira Sans

shinenelson commented 9 years ago

@jsx, would it be a better idea to use pre-defined images for the backside because it wouldn't be edited at all? That would ensure smaller size because we wouldn't have to include the fonts explicitly. And we're doing it the template way, should we change all the fonts to Open Sans?

Waiting for your comment to start working on this issue.

riverspirit commented 9 years ago

Change the fonts of the Reps and FSA cards to Open Sans.

Please leave the original template as is.

would it be a better idea to use pre-defined images for the backside because it wouldn't be edited at all?

The way it is now is fine.

shinenelson commented 9 years ago

I personally feel the look of the Reps card and FSA card doesn't appeal as well as the mozillians card does.

Whatever, that is just my personal opinion. Please close the issue and mark wontfix if irrelevant.

~ shine

On Tue, Nov 4, 2014 at 6:01 PM, jsx notifications@github.com wrote:

Change the fonts of the Reps and FSA cards to Open Sans.

Please leave the original template as is.

would it be a better idea to use pre-defined images for the backside because it wouldn't be edited at all?

The way it is now is fine.

— Reply to this email directly or view it on GitHub https://github.com/MozillaKerala/Card-Generator/issues/11#issuecomment-61632798 .

riverspirit commented 9 years ago

As I said, leave the original card as is and change the font on the new cards if you feel like.

shinenelson commented 9 years ago

leave the original card as is

As in Reps Card 1?

change the font on the new cards if you feel like.

Tanay's cards or incoming cards in the future?

~ shine

On Tue, Nov 4, 2014 at 6:17 PM, jsx notifications@github.com wrote:

As I said, leave the original card as is and change the font on the new cards if you feel like.

— Reply to this email directly or view it on GitHub https://github.com/MozillaKerala/Card-Generator/issues/11#issuecomment-61634542 .

riverspirit commented 9 years ago

As in Reps Card 1?

Yes. The original reddish card.

Tanay's cards or incoming cards in the future?

Tanay's card. We can't tell if future cards need font change until we see them.

shinenelson commented 9 years ago

I'll modify Tanay's cards.

But again, another opinion required - should I make the changes with HTML or just pre-defined images?

Making changes to the HTML template would require adding the fonts to the repo (I don't prefer calling fonts from the google repository - for privacy reasons - they f***ing track you even from the fonts). But that would mean larger size of the repo.

Pre-defined images wouldn't cost much size. They cannot be modified anyway. So, pre-defined images for the back side of the cards are an option too.

Waiting for your opinion @jsx

~ shine

On Tue, Nov 4, 2014 at 6:35 PM, jsx notifications@github.com wrote:

As in Reps Card 1?

Yes. The original reddish card.

Tanay's cards or incoming cards in the future?

Tanay's card. We can't tell if future cards need font change until we see them.

— Reply to this email directly or view it on GitHub https://github.com/MozillaKerala/Card-Generator/issues/11#issuecomment-61636381 .

riverspirit commented 9 years ago

HTML or just pre-defined images?

No full page images for now. Just markup using HTML

Regarding self hosting fonts

It doesn't really matter. We already have Google Analytics installed in the site. Anyway, self hosting font is ok. Just make sure everything works.