search

MozillaKerala / Card-Generator

Visiting card generator for the Mozilla community
http://cards.mozillakerala.org
MIT License
42 stars 45 forks source link

Fonts for DOMPDF #15

Closed shinenelson closed 10 years ago

shinenelson commented 10 years ago

PS : sorry, for the multiple PRs, I just could get my head wrapped around the idea of reset in branches to go back in commits. One reset went fine, so the PR, but the subsequent commits and PRs were all messed up that only deleting and re-uploading the branch was the only option. I won't send in the same PR again. Sorry for the inconvenience caused. This one is the final PR with the same description and title. :smiley:

shinenelson commented 10 years ago

@jsx, did you deliberatly miss out on PR (https://github.com/MozillaKerala/Card-Generator/pull/15)? Now, I have to make all these changes again to the new merged repo. :disappointed_relieved:

I had 4 PRs in queue and was waiting for this one to be merged or rejected before, I could send in the next PR. :cold_sweat: :sob: :angry:

PS : You haven't responded to me for the past few days, anywhere. Anything wrong with me? Grudge, perhaps? :open_mouth: :frowning: :anguished: :confused: :worried:

riverspirit commented 10 years ago

Was busy with work. This one has a few files changed/new, so I need tome to review before merging. Will check tomorrow.

shinenelson commented 10 years ago

it's just font additions. not much changes in files. and now, that you've merged (https://github.com/MozillaKerala/Card-Generator/pull/16), I'll have to pull those changes into my repo before I can send in a PR right?

~ shine

On Sat, Nov 8, 2014 at 1:11 AM, jsx notifications@github.com wrote:

Was busy with work. This one has a few files changed/new, so I need tome to review before merging. Will check tomorrow.

— Reply to this email directly or view it on GitHub https://github.com/MozillaKerala/Card-Generator/pull/15#issuecomment-62200608 .

riverspirit commented 10 years ago

No need to pull and send PR again.