Core Fixes (Fonts, mPDF, CSS Separation, CSS Relative path, CSS Injection, Readme)

MozillaKerala / Card-Generator

Visiting card generator for the Mozilla community

http://cards.mozillakerala.org

MIT License

42 stars 45 forks source link

Core Fixes (Fonts, mPDF, CSS Separation, CSS Relative path, CSS Injection, Readme) #46

Closed gabrielmicko closed 8 years ago

gabrielmicko commented 8 years ago

These core fixes may cause other pull requests expire.

riverspirit commented 8 years ago

Since this is a humongous PR, it is going to take me some time to review and merge this.

Please consider making smaller PRs in the future.

gabrielmicko commented 8 years ago

You are right, but In this case I couldn't!

gabrielmicko commented 8 years ago

Could you please evaluate this PR?

Mte90 commented 8 years ago

riverspirit commented 8 years ago

Sorry about the delay. I'll get to it as soon as I can.

gabrielmicko commented 8 years ago

+1 please

Mte90 commented 8 years ago

riverspirit commented 8 years ago

Sorry for the delay, I've merged the PR. But there is an issue. Images aren't showing up in the generated pdf.

gabrielmicko commented 8 years ago

I'll check it soon!

gabrielmicko commented 8 years ago

So there is no problem in my development environment. http://mozilla.kreszkviz.hu/Card-Generator/

gabrielmicko commented 8 years ago

Sorry for the commit noise. If the images wont show up on your dev environment please set the $GLOBALS['SUBDIR'] = '/Card-Generator'; like this. Replace Card-Generator to your sub folder is necessary.