Fixed the dummy option menu, added functionality and added Mozillians Card template

[riverspirit]

Hi @tanay1337, thanks again. Before I can merge the changes, a couple of changes are needed.

1. Please keep the existed template at the default one. And name it Reps Card 1.
2. Your new reps card can be named Reps Card 2
3. Rename FSAs Card to FSA Card
4. Also please list the templates in the above order in the list select boc (existing reps card, new reps card, new fsa card)

I would've also asked to rename the template filenames to remove the spaces and replace them with hyphens or underscores, but since that would make you have to adapt the JS code, that's ok for now.

Thanks for taking the time!

[tanay1337]

Hi @riverspirit, if we remove the numbering the default would be the fsa card as the php code for the option tag reads alphabetically, so that would create a problem! Other than that the order can be changed till we keep the numbers in the beginning. Please advice.

[riverspirit]

Can you remove the code to automatically list the templage pages altogether and just hardcode the three template files in the select box? The automatic listing seems to be an overkill :stuck_out_tongue:

[tanay1337]

Yeah, did that and added a new Mozillians-card template, however I did like the automatic listing :D

[riverspirit]

:monkey_face: thank u

[tanay1337]

No problem :) When will it be up on cards.mozillakerala.org?

[riverspirit]

@shinescodes, you can move to server whenever you get time (Probably after exams)

[riverspirit]

@tanay1337, probably in a week - in the coming weekend or so. I'll ping you once uploaded.

[shinenelson]

If the changes are production ready, I'll push the changes right away @riverspirit.

@tanay1337, thank you for your contribution. We're happy to have you work on Cards Generator.

[tanay1337]

@shinescodes I believe the changes are production ready. Happy to help :)

[riverspirit]

@shinescodes, yeah, go ahead :rocket:

[tanay1337]

@riverspirit @shinescodes I think the width of the image in the mozillians card needs to be adjusted! Otherwise looking good :)

[riverspirit]

@tanay1337, a pull request for the width fix is much appreciated.

[shinenelson]

The changes have been pushed to the server.

But I think the width of the image in the Mozillian card need to adjusted. @tanay1337, can you make a quick change to it?

[shinenelson]

oops, the error was already detected... ;)

anyways, waiting for the PR merge @riverspirit @tanay1337.

[riverspirit]

I'm off to bed :sleepy:

[tanay1337]

@shinescodes Done!