search

MozillaKerala / Card-Generator

Visiting card generator for the Mozilla community
http://cards.mozillakerala.org
MIT License
42 stars 45 forks source link

Implemented the functionality to generate back side of the card #9

Closed tanay1337 closed 10 years ago

tanay1337 commented 10 years ago

Many people who actually wanted to print this card had concerns about the back-side of the card, so here it comes!

riverspirit commented 10 years ago

Awesome! But looks like you accidentally removed the piwik tracking code that @shinescodes had added yesterday after merging your PR. Can you re-add the piwik tracking code under the Google Analytics tracking code?

<!-    Piwik Analytics  -->
<script type="text/javascript">
    var _paq = _paq || [];
    _paq.push(['trackPageView']);
    _paq.push(['enableLinkTracking']);
    (function() {
        var u="//piwik.mozillakerala.org/";
        _paq.push(['setTrackerUrl', u+'piwik.php']);
        _paq.push(['setSiteId', 6]);
        var d=document, g=d.createElement('script'), s=d.getElementsByTagName('script')[0];
        g.type='text/javascript'; g.async=true; g.defer=true; g.src=u+'piwik.js'; s.parentNode.insertBefore(g,s);
    })();
</script>

<noscript>
    <p><img src="//piwik.mozillakerala.org/piwik.php?idsite=6" style="border:0;" alt="" /></p>
</noscript>
<!-- End Piwik Code -->
riverspirit commented 10 years ago

I've merged it. I'll add the code again. Thanks!

tanay1337 commented 10 years ago

Welcome again! When will it be pushed to production?

riverspirit commented 10 years ago

Probably before this weekend is over, as @shinescodes gets time.

shinenelson commented 10 years ago

@jsx, I'll merge any changes as and when it is production ready and I have enough network coverage to do an ssh and maintain it. You don't have to mention every time "whenever I get the time", I always have time for Mozilla Kerala. Everything else is secondary. ;)

Next time, just ping me and ask me to merge the changes.

~ shine

On Tue, Nov 4, 2014 at 4:23 PM, jsx notifications@github.com wrote:

Probably before this weekend is over, as @shinescodes https://github.com/shinescodes gets time.

— Reply to this email directly or view it on GitHub https://github.com/MozillaKerala/Card-Generator/pull/9#issuecomment-61622959 .

tanay1337 commented 10 years ago

@shinescodes :D I have done some testing, I believe the code is now production ready :)

shinenelson commented 10 years ago

@tanay1337, The changes are live.

I have a few suggestions to make, though, could you change the font on the back of the Reps card to Open Sans and change the font of mozilla to the official Meta Bold, it looks kind of under-done now, there is something odd-looking and lack of professionalism in it.

When I saw the initial design by Elio Qoshi, I had tried to attempt to build what you just contributed. But due to other engagements, I couldn't complete it. Thank you for completing it. :wink:

But I had built the back side for the FSA card using the original logo of FSA. Attaching 2 versions of the same. (I'm not sure whether github will serve attachments from email.)

Also, it would be great if you could make the generation of the cards in a new tab rather than the same tab.

All these are changes that I would like to see. I'm suggesting because you're currently actively working on it. But if you're busy with other engagements, I wouldn't mind making the changes :smile: . Please Leave a note whether you can or cannot make the suggested changes.

Also @jsx, waiting for your opinion on my suggestions.

~ shine

On Tue, Nov 4, 2014 at 4:35 PM, Tanay Pant notifications@github.com wrote:

@shinescodes https://github.com/shinescodes :D I have done some testing, I believe the code is now production ready :)

— Reply to this email directly or view it on GitHub https://github.com/MozillaKerala/Card-Generator/pull/9#issuecomment-61624258 .

shinenelson commented 10 years ago

@tanay1337, another suggestion :

since HTML5, 'www' is deprecated and not a mandatory requirement in URLs right? seeing that you worked on a HTML5 compliance fix too, I think removing the www from the mozilla.org link would be better-looking. Not that it is an issue. Just a suggestion. Don't necessarily have to fix that though. :wink:

~ shine

On Tue, Nov 4, 2014 at 4:59 PM, shine nelson radioactive.life@gmail.com wrote:

@tanay1337, The changes are live.

I have a few suggestions to make, though, could you change the font on the back of the Reps card to Open Sans and change the font of mozilla to the official Meta Bold, it looks kind of under-done now, there is something odd-looking and lack of professionalism in it.

When I saw the initial design by Elio Qoshi, I had tried to attempt to build what you just contributed. But due to other engagements, I couldn't complete it. Thank you for completing it. :wink:

But I had built the back side for the FSA card using the original logo of FSA. Attaching 2 versions of the same. (I'm not sure whether github will serve attachments from email.)

Also, it would be great if you could make the generation of the cards in a new tab rather than the same tab.

All these are changes that I would like to see. I'm suggesting because you're currently actively working on it. But if you're busy with other engagements, I wouldn't mind making the changes :smile: . Please Leave a note whether you can or cannot make the suggested changes.

Also @jsx, waiting for your opinion on my suggestions.

~ shine

On Tue, Nov 4, 2014 at 4:35 PM, Tanay Pant notifications@github.com wrote:

@shinescodes https://github.com/shinescodes :D I have done some testing, I believe the code is now production ready :)

— Reply to this email directly or view it on GitHub https://github.com/MozillaKerala/Card-Generator/pull/9#issuecomment-61624258 .

tanay1337 commented 10 years ago

@shinescodes I feel that www looks good ;) I agree strongly with both suggestions of yours, I have fixed the card to be generated in a new tab (https://github.com/MozillaKerala/Card-Generator/pull/10). Although, I did wish to implement mozilla in its original font, but was unable to do it ( not much of a designer :D )!

riverspirit commented 10 years ago

Also, it would be great if you could make the generation of the cards in a new tab rather than the same tab.

No, please.

since HTML5, 'www' is deprecated and not a mandatory requirement in URLs right?

Lots of misleading information. I don't think www was ever a requirement in URLs. And HTML5 doesn't dictate how URL's are constructed.

riverspirit commented 10 years ago

@shinescodes, pls add new suggestions in the issues section.

shinenelson commented 10 years ago

@tanay1337, then I'll do the designing part. Commit comming in very soon @jsx. :smiley:

~ shine

On Tue, Nov 4, 2014 at 5:21 PM, jsx notifications@github.com wrote:

Also, it would be great if you could make the generation of the cards in a new tab rather than the same tab.

No, please.

since HTML5, 'www' is deprecated and not a mandatory requirement in URLs right?

Lots of misleading information. I don't think www was ever a requirement in URLs. And HTML5 doesn't dictate how URL's are constructed.

— Reply to this email directly or view it on GitHub https://github.com/MozillaKerala/Card-Generator/pull/9#issuecomment-61628877 .

shinenelson commented 10 years ago

@jsx, thank you for pointing it out. I just noticed it from another repo (at the same time that you mentioned it) that the issues section could be used for suggesting changes and not just bugs.

shinenelson commented 10 years ago

Issue for changing fonts have been opened at (https://github.com/MozillaKerala/Card-Generator/issues/11)

shinenelson commented 10 years ago

I'll let you know when the changes are live @tanay1337. :smile:

~ shine

On Tue, Nov 4, 2014 at 4:21 PM, Tanay Pant notifications@github.com wrote:

Welcome again! When will it be pushed to production?

— Reply to this email directly or view it on GitHub https://github.com/MozillaKerala/Card-Generator/pull/9#issuecomment-61622741 .