The Jank Detector wrongly blocked the website in the focused window even though a different website triggered it - Githubissues

MozillaReality / FirefoxReality

INACTIVE - A fast and secure browser for standalone virtual-reality and augmented-reality headsets.

https://mzl.la/reality

Mozilla Public License 2.0

768 stars 217 forks source link

The Jank Detector wrongly blocked the website in the focused window even though a different website triggered it #1657

Closed Softvision-GeluHaiduc closed 3 months ago

Softvision-GeluHaiduc commented 5 years ago

[Affected Versions]:

Firefox Reality 1.4-32352315

[Affected Platforms]:

Oculus Go - Android 7.1.2
Oculus Quest - Android 7.1.1
HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

The headset is turned on and the browser is opened.

[Steps to reproduce]:

Navigate to a website eg: "facebook.com".
Click on the “+” button from the tray to open a new window.
On the new window navigate to the following website: "shadertoy.com".
While the "shadertoy.com" website is loading focus the other window.
Observe the website for which the "Poor Site Performance" is detected.

[Expected results]:

The "Poor Site Performance" pop up is displayed in front of the window with the "shadertoy.com" website opened.

[Actual results]:

The "Poor Site Performance" pop up is displayed in front of the website that was navigated to first.
The website that was navigated to first is the one blocked even though the "shadertoy.com" website is the one that triggered the pop up.

[Notes]:

The website that triggered the "Poor Site Performance" pop up is not blocked.
The "Poor Site Performance" pop up is triggered again when the window with the "shadertoy.com" website is focused.
Attached a screen recording of the issue here.

bluemarvin commented 5 years ago

There is no way to currently detect which window is causing the jank so the Performance Monitor will be disabled for 1.4: https://github.com/MozillaReality/FirefoxReality/pull/1662

Hopefully we can re-enable it for 1.5