MozillaReality / FirefoxReality

INACTIVE - A fast and secure browser for standalone virtual-reality and augmented-reality headsets.
https://mzl.la/reality
Mozilla Public License 2.0
768 stars 217 forks source link

A page that was bookmarked in PB appears as a visited page in the awesomebar suggestions #2834

Closed Softvision-GeluHaiduc closed 3 months ago

Softvision-GeluHaiduc commented 4 years ago

[Affected Versions]:

[Affected Platforms]:

[Prerequisites]:

[Steps to reproduce]:

  1. Click the Private Browsing button in the menu tray.
  2. Navigate to a webpage and bookmark it. (e.g. puma.com)
  3. Exit PB and click inside the awesomebar.
  4. Type inside the awesomebar “puma”.
  5. Observe the suggestions.

[Expected results]:

[Actual results]:

[Notes]:

keianhzo commented 4 years ago

Same behavior for Fenix, it seems to be something AS related. I've pinged the Rust components team on slack.

keianhzo commented 4 years ago

AS team reported:

it’s intentional that we suggest bookmarks as well—we give bookmarks a boost in the results because bookmarking is a user action, so we think they might want to visit the page again

We don't show (don't even receive) time stamp information about history suggestions so I think it's safe to show it given that they will show in the bookmarks anyway as there is no such thing as Private Mode Bookmarks.

@emstanley @bluemarvin We can push this if anybody feels that it shouldn't show up, the AS team was open to change this behavior based on what is the expected behavior is.