search

MozillaReality / WebXR-emulator-extension

WebXR emulator extension
Mozilla Public License 2.0
454 stars 55 forks source link

Update and add oculus device configs #280

Closed felixtrz closed 2 years ago

felixtrz commented 2 years ago

This PR is the first of a series of changes that breaks down https://github.com/MozillaReality/WebXR-emulator-extension/pull/278. It adds/updates support for all Oculus devices, fixing the incorrect profile name provided in WebXR Polyfill (previously when you select oculus quest, the emulator incorrectly emits the profile name of oculus-touch, which is supposed to be oculus-touch-v2, fixed in the PR to webxr-polyfill)

I've changed the dependency of webxr polyfill to a custom version of mine on github, which is pending review here: https://github.com/immersive-web/webxr-polyfill/pull/163/ I have that landed asap and will change the dependency to the official webxr-polyfill once that happens.

Will appreciate review and feedback, thanks! @takahirox

takahirox commented 2 years ago

Thanks for making a smaller PR! I will review it. Please note that it may take time because I'm on parental leave now.

takahirox commented 2 years ago

Would you mind if removing polyfill/webxr-polyfill.js from this PR because I will separately build and commit it?

takahirox commented 2 years ago

Thanks for your patience!