search

MozillaReality / horizon

(2015) Horizon was an experimental VR browser built on web standards using CSS-VR.
http://mozvr.github.io/horizon/web/
Other
1 stars 0 forks source link

`FrameManager` is not getting called anywhere #221

Closed cvan closed 9 years ago

cvan commented 9 years ago

FrameManager is no longer getting initalised in browser.js, and as such the FrameManager#init method isn't called, so none of the mouse events, keyboard inputs, and gamepad inputs are getting set up.

Looks like it's probably the culprit to #216, #217, #219, #220. It probably won't immediately fix all those issues, but it looks like a start.

cvan commented 9 years ago

Or maybe FrameManager has been superseded by these other components. It's a bit hard to tell. @KevinGrandon?

KevinGrandon commented 9 years ago

Yup, the idea here is that we want to move everything into browser.js or other components.

Frame manager just remains in the code base so it's clear what's left to migrate. Sorry for not being more clear there.

cvan commented 9 years ago

Oh, shoot, okay. There's a lot of code in there to migrate.

KevinGrandon commented 9 years ago

Oh, shoot, okay. There's a lot of code in there to migrate.

There's a fair amount yeah, but it should go pretty quickly. I recommend handling it piece by piece to fix the issues listed in your original comment. I'll be around to help out :)

cvan commented 9 years ago

okay, no problemo. I'll close this issue. as long as @caseyyee too knows where to look. thanks!

caseyyee commented 9 years ago

Yup, already working on these :)