move settings into its own file

[KevinGrandon]

I think a lot of these things maybe shouldn't be settings in the first place? Is there value in making each .wav sound a setting for example? Presentational stuff like that should probably just go into the component IMO. In the future you can go as far as swapping out entire components based on definitions, instead of global attributes.

(I did end up moving a fair amount of these settings into each sub component in the react refactor)

[cvan]

it feels like things that can be changed like the Start Page URL should be defined as a setting in a settings file, not as a const in the component. it becomes hard, at least for me, to know which file to look in to flip things. I know we've all hand to change the Start Page URL locally many times.

paths to assets like audio files? well, I don't expect those to change that often, so maybe that's fine to keep them hardcoded in the components.

but something like the URL to the directory? I see value in keeping that as a configurable setting so you can point elsewhere.

@jcarpenter @caseyyee thoughts?

[KevinGrandon]

Yeah, I think it makes sense for certain things. For things like default start page, that should probably go into mozSettings. Also we'll probably need to start putting more things in mozSettings - whenever we want user configuration. Having a file for default settings values makes sense for that :+1:

[caseyyee]

I think the audio file references make more sense as const in the hud component along with all the other layout and presentation.

All other global constants/reuseable settings can remain in the settings.

[cvan]

I think the audio file references make more sense as const in the hud component along with all the other layout and presentation.

All other global constants/reuseable settings can remain in the settings.

I can get behind that :waning_crescent_moon:

[cvan]

rr?

[KevinGrandon]

R+, though I still prefer camelBack instead_of_underscores for the actual setting names also. Not a blocker to land though.

[cvan]

I'm cool with that. I think I see underscores used more often for settings, but I'll change to camelCase for consitency.

I've never heard it called camelBack. that's adorable :camel: !

[KevinGrandon]

I've never heard it called camelBack. that's adorable :camel: !

Heh, not sure if I'm old school or what, but we used to always refer to them as: CamelCase and camelBack (the difference being whether or not the first letter is capital). Pretty much everyone uses a different name for these though.

[cvan]

I guess you are right!

:camel: ^{are you my mother?}

[KevinGrandon]

I want this for #225 so going to merge it. Feel free to update the settings key names to camelCase in master if you want. Thanks!

[cvan]

thanks

[cvan]

camelBack, you mean :panda_face: