MozillaReality / horizon

(2015) Horizon was an experimental VR browser built on web standards using CSS-VR.
http://mozvr.github.io/horizon/web/
Other
1 stars 0 forks source link

gracefully handle babelify errors in gulp (fixes #247) #248

Closed cvan closed 9 years ago

cvan commented 9 years ago

when you cause a babelify error, the 'babelify' gulp task would never finish, causing the 'watch' task to never finish. so you'd have to restart gulp every time that happened.

while I was at it, I fixed the error message and formatting so we actually return the entire stack trace instead of just the error message. :tada:

before

screenshot 2015-07-28 17 35 48

after

screenshot 2015-07-28 17 35 26

cvan commented 9 years ago

we could do some long-term solution like using https://www.timroes.de/2015/01/06/proper-error-handling-in-gulp-js/

but I feel like this is sufficient. thoughts?

KevinGrandon commented 9 years ago

This seems fine to me for now, thanks! R+!

cvan commented 9 years ago

thanks :)