search

MozillaReality / horizon

(2015) Horizon was an experimental VR browser built on web standards using CSS-VR.
http://mozvr.github.io/horizon/web/
Other
1 stars 0 forks source link

fix gamepad + tile `:active` states (fixes #218) #249

Closed cvan closed 8 years ago

KevinGrandon commented 8 years ago

Haven't tested it, but looks pretty good to me. Can you also remove the old, duplicated code in frame_manager.js along with this? (Or potentially just remove that entire file if it's mostly migrated now)

cvan commented 8 years ago

Can you also remove the old, duplicated code in frame_manager.js along with this? (Or potentially just remove that entire file if it's mostly migrated now)

sure thing! yeah, I had originally done it as part of this PR. but thought I'd do it separately: PR #250

caseyyee commented 8 years ago

Seems to work nicely :) Thanks for this :+1: r+

caseyyee commented 8 years ago

Also, just checked with Xbox 360 controller. I don't have a PS3 controller on-hand, but it looks like the mappings are just carried over, so it should be fine.

cvan commented 8 years ago

thanks, @caseyyee!