MozillaReality / immersive-custom-elements

Immersive Custom Elements
https://mixedreality.mozilla.org/immersive-custom-elements/examples/index.html
Mozilla Public License 2.0
134 stars 8 forks source link

Create independent js for each element #34

Closed fernandojsg closed 5 years ago

fernandojsg commented 5 years ago

In case you just want to use the image360 element you don't want to include the whole js. Still it's useful to have the whole bundle in case people want to use more than one though

takahirox commented 5 years ago

Currently I don't think that. A custom element consists of Three.js, common utility functions, and element specific code. The element specific code is just 50-100 lines. If I make independent js files, it ends up 99% of code are same across js files.

I'll think of that option when custom elements are many or big.