search

MozillaReality / immersive-custom-elements

Immersive Custom Elements
https://mixedreality.mozilla.org/immersive-custom-elements/examples/index.html
Mozilla Public License 2.0
134 stars 8 forks source link

Consistency on dashes for elements names #36

Closed fernandojsg closed 5 years ago

fernandojsg commented 5 years ago

Just to keep consistency it feels weird that we have <img-360>, <video-360> and <img360-tour> with dashes, but then <img360>. I believe for consistency it should be <img-360-tour> and Ideally we could be using img-360 too for the item, just behaving differently if it's embedded into a img-360-tour. Or at least in the meantime we could use something like img-360-tour-image, img-360-tour-item or similar to keep that consistency.

takahirox commented 5 years ago

<img-360-tour>

I thought dash can be used only once in the name but seems I was wrong. I'll update.

https://html.spec.whatwg.org/multipage/custom-elements.html#valid-custom-element-name

Ideally we could be using img-360 too for the item

I think naming differenty can make the code simpler. I'll adopt <img-360-tour-item>.

takahirox commented 5 years ago

Closing in favor of #37