MozillaReality / webxr-ios-js

INACTIVE - A JS implementation of WebXR used *only* in Mozilla's WebXR Viewer
Mozilla Public License 2.0
71 stars 30 forks source link

Newer hit test API and input event support #82

Closed takahirox closed 4 years ago

takahirox commented 4 years ago

This PR adds

With this change, for example the following WebXR AR applications start to work

(See #80 if you want to try Three.js examples.)

Note that this change breaks the examples in splash.html using old hit test API. We should update them in another PR.

Another note, currently it takes offset ray direction but doesn't take offset ray origin in this PR. As we discussed in slack, we may change to

let's do them in another PR if needed because I don't want to make this PR further bigger.

blairmacintyre commented 4 years ago

@joshmarinacci I don't have time to review this, unfortunately.

takahirox commented 4 years ago

What are the tests that you are using to validate it?

I tested on the existing WebXR AR examples I listed in the PR comment. Let me know if any (automatic) tests we should validate.

joshmarinacci commented 4 years ago

looks good to me.

joshmarinacci commented 4 years ago

you can merge it now