search

MozillaSecurity / lithium

Line-based testcase reducer
Mozilla Public License 2.0
94 stars 25 forks source link

Lint fixes #5

Closed nth10sd closed 8 years ago

nth10sd commented 8 years ago

As per #4, this PR fixes the majority of issues (excluding globals) pointed out by various linters (pep8, pep257, Mc Cabe, pyflakes, pylint). I had set up the linter-python extension in Atom to look for these issues.

I've tried to separate out the changes to different atomic commits. For whitespace changes, check out this neat GitHub trick.

I'm not entirely sure about the last commit. Is the repeat variable really not used? How should the code be fixed? I can remove this commit from the PR if needed.

@jruderman and @tysmith, I would appreciate if you can take a look. Thanks!

nth10sd commented 8 years ago

For @nbp's commit, I had cherry-picked from his PR.

nth10sd commented 8 years ago

I'm made improvements as suggested, also tweaked a docstring after a f2f conversation w/ @jruderman.

If this looks good, let's merge it! Thanks everyone!