search

MozillaSecurity / lithium

Line-based testcase reducer
Mozilla Public License 2.0
95 stars 25 forks source link

Fix #57 - Optimize removing large chunks #58

Closed tysmith closed 6 years ago

tysmith commented 6 years ago

This optimization will avoid testing with empty testcases.

codecov-io commented 6 years ago

Codecov Report

Merging #58 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   84.58%   84.61%   +0.02%     
==========================================
  Files          13       13              
  Lines        1706     1709       +3     
==========================================
+ Hits         1443     1446       +3     
  Misses        263      263
Impacted Files Coverage Δ
src/lithium/reducer.py 80.99% <100%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e141c9a...06759f0. Read the comment docs.

jschwartzentruber commented 6 years ago

Looks good. Thanks!

One think lacking from the description is that the 2nd part with chunk size 4096 will still get tried (empty testcase). This is good, because we'll still detect a bad build right away when the testcase is irrelevant and gets reduced to empty.