MozillaSecurity / lithium

Line-based testcase reducer
Mozilla Public License 2.0
94 stars 25 forks source link

Use str.splitlines consistently when splitting testcases #82

Closed jschwartzentruber closed 3 years ago

jschwartzentruber commented 3 years ago

Particularly when searching for DDBEGIN/END lines.

str.splitlines recognizes a bunch of extra possible newlines: https://docs.python.org/3/library/stdtypes.html?highlight=str%20splitlines#str.splitlines

codecov[bot] commented 3 years ago

Codecov Report

Merging #82 (1a81284) into master (4127414) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   83.28%   83.32%   +0.03%     
==========================================
  Files          14       14              
  Lines        1370     1373       +3     
==========================================
+ Hits         1141     1144       +3     
  Misses        229      229              
Impacted Files Coverage Δ
src/lithium/reducer.py 87.41% <ø> (ø)
src/lithium/interestingness/timed_run.py 82.66% <100.00%> (ø)
src/lithium/testcases.py 98.05% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4127414...1a81284. Read the comment docs.