search

Mpdreamz / shellprogressbar

ShellProgressBar - display progress in your console application
MIT License
1.43k stars 134 forks source link

Dependency on System.Text.Encoding.CodePages #16

Closed thoemmi closed 6 years ago

thoemmi commented 6 years ago

Currently ShellProgressBar has a dependency on System.Text.Encoding.CodePages. However, I cannot see any reference to that package except in ShellProgressBar.Example. Is the dependency really required?

Mpdreamz commented 6 years ago

https://github.com/Mpdreamz/shellprogressbar/blob/d0481de8141016a03c7d58403633cedc01cf907f/src/ShellProgressBar/ProgressBarBase.cs#L12 uses it as well to make sure UTF-8 characters are printed correctly on codepages .NET core does not know about OOTB.

Is this dependency causing any issues?

thoemmi commented 6 years ago

Oh, for whatever reason I missed that line. Sorry for bothering you.

Mpdreamz commented 6 years ago

No bother!