search

Mpdreamz / shellprogressbar

ShellProgressBar - display progress in your console application
MIT License
1.44k stars 134 forks source link

Change interface Tick() signature to match implementation #33

Closed kjaleshire closed 5 years ago

kjaleshire commented 5 years ago

Typing a ProgressBar or ChildProgressBar as IProgressBar causes calls to Tick() to use the interface signature which is currently void Tick(string message = ""). This passes a default empty string value to the implementation, which erases any existing message.

tl;dr This fixes an issue where in some situations setting a message then calling Tick() would cause the message to disappear.

A current workaround is to call Tick(null).

Mpdreamz commented 5 years ago

Thank you for taking the time to address this @kjaleshire

Sorry it took forever for me to come back to this PR.

Mpdreamz commented 5 years ago

This is now finally released: https://www.nuget.org/packages/ShellProgressBar/4.3.0