Mqxx / GitHub-Markdown

Additional Markdown for GitHub.
GNU General Public License v2.0
82 stars 11 forks source link

New designs #1

Closed digitalghost-dev closed 1 year ago

digitalghost-dev commented 1 year ago

Hey, opening an issue for new badges. Some suggestions:

I'm pulling inspiration from Obsidian callouts

Mqxx commented 1 year ago
  • Checkmark but with label says "success" and/or "working"

Okay I will add both of them. But, there is already a checkmark with success.

Mqxx commented 1 year ago

I have added the "Danger" badge with this icon

Mqxx commented 1 year ago

I'm following the GitHub design guidelines

digitalghost-dev commented 1 year ago
  • Checkmark but with label says "success" and/or "working"

Okay I will add both of them. But, there is already a checkmark with success.

Yes, but just wanted different labels that is more meaningful. Cool, thanks for the link on the design link. How do you feel about a tip badge?

Mqxx commented 1 year ago

What color sould I use for the "Tip" badge?

digitalghost-dev commented 1 year ago

Black or gray?

Mqxx commented 1 year ago

Thats exacly what I have thought of 😄

Mqxx commented 1 year ago

Added!

digitalghost-dev commented 1 year ago

Danger one looks good! The gray might be too light? I opened up the svg file and it's a bit hard to see.

Mqxx commented 1 year ago

Yea I know but in a dark markdown file I think it looks good.

Mqxx commented 1 year ago
  • Checkmark but with label says "success" and/or "working"

I'm not quite sure about the "alternate success badges" yet, because like I said I'm sticking to the GitHub styling guidelines

digitalghost-dev commented 1 year ago

Should there be a light/dark version for tip? I use light mode a lot lol

Mqxx commented 1 year ago

Should there be a light/dark version for tip? I use light mode a lot lol

Oh yea I can also create a light and dark color theme of each badge

Mqxx commented 1 year ago

Added! https://github.com/Mqxx/GitHub-Markdown/blob/main/blockquotes/badge/light-theme/tip.svg

digitalghost-dev commented 1 year ago

Awesome. They look great.

Mqxx commented 1 year ago

Anything else?

digitalghost-dev commented 1 year ago

Do you like the idea of an "example" badge?

Mqxx commented 1 year ago

Yea maybe. What Icon should I use?

digitalghost-dev commented 1 year ago

Maybe this one?

Mqxx commented 1 year ago

Yea I think this looks good. What color?

digitalghost-dev commented 1 year ago

Maybe blue like the note icon?

digitalghost-dev commented 1 year ago

or a turquoise?

Mqxx commented 1 year ago

I try the blue one

Mqxx commented 1 year ago

Do you like the idea of an "example" badge?

Added!

digitalghost-dev commented 1 year ago

Cool! I was look at the GitHub styling guide that you linked and in the color section, it shows the checkmark being used for "successful" or "passing"

Mqxx commented 1 year ago

okay

Mqxx commented 1 year ago

Should I rename the badge instead?

digitalghost-dev commented 1 year ago

Yeah, probably a better idea

Mqxx commented 1 year ago

Changed!

Mqxx commented 1 year ago

Any other suggestions or can I close the issue now?

digitalghost-dev commented 1 year ago

I think that's a good list! Thanks for doing this. It can be closed.