search

Mr-Markus / ZigbeeNet

A .NET Standard library for working with ZigBee
Eclipse Public License 1.0
131 stars 47 forks source link

closes #78 #107

Closed nicolaiw closed 4 years ago

nicolaiw commented 4 years ago

I searched for "Log.Error" and adjusted the messageTemplate where needed (hope I've caught all :))

Mr-Markus commented 4 years ago

Well done. This helps a lot :-)

spudwebb commented 4 years ago

@nicolaiw , @Mr-Markus, have you actually tested this change? from my tests, this kind of line: Log.Error(ex, "Error: {Exception}"); doesn't log the exception, it just prints "Error: {Exception}", you have to pass the exception message as a parameter for the {Exception} template to be replaced:

Log.Error(ex, "Error: {Exception}", ex.Message);

I fixed it for example in ZigbeSerialPort.cs in PR #109

nicolaiw commented 4 years ago

https://github.com/Mr-Markus/ZigbeeNet/pull/110