search

Mr-Markus / ZigbeeNet

A .NET Standard library for working with ZigBee
Eclipse Public License 1.0
131 stars 47 forks source link

Correcting the folder names #55

Closed Gallimathias closed 5 years ago

Gallimathias commented 5 years ago

Names the physical folder names as it is in the sln to improve communication and collaboration.

Mr-Markus commented 5 years ago

I understand what you mean and it would be a goog idea, but take a look at the CI results because there are over 116 error messages :-(

Gallimathias commented 5 years ago

yea i see Appveyor dind't see the path changes :D

Gallimathias commented 5 years ago

now it should be fixed

Gallimathias commented 5 years ago

Master merged to resolve conflicts

Gallimathias commented 5 years ago

@Mr-Markus now you can merge :D

Mr-Markus commented 5 years ago

@Gallimathias OK I will merge it after merge PR #60 because think it is easier to resolve conflicts. If you think other way just say it :-)

PS: I am on vacation until Sunday and will do it after it

Mr-Markus commented 5 years ago

Hm, there are many conflicts now... I also took a look at it and have to say that a src folder seems to be a more "state-of-the-art" naming convention for source code folders. So i would prefer to change the name in the sln file, instead of renaming folderstructure.

Do you think you can change this in this PR? Otherwise I would suggest to create a new feature branch from last master (or develop) branch and change it there

@nicolaiw jfyi

Gallimathias commented 5 years ago

Yes, the conflicts come from the fact that you always work directly on the branch. I merge them into my branch then they are solved.

Git realizes that this is renames-

The "separation" comes because more and more web projects exist. In fact it is common for JavaScript and Co. to have a lowercase src folder.

But with C# the folder structure has a different convention. I see in many projects that adhere to a "web" structure difficulties in the communication of the collaborators. Not to mention all the tools which are based on the C# standard for C#.

Ultimately you can handle this like you want but I would find a C# standard for a C# project better as I would find a web standard for web projects better ^^

Gallimathias commented 5 years ago

P.s. if you want us to use src I can change that for you. Then it would be good to decide what comes under src and what doesn't. It would also be good to use rules to determine if you want to keep the folder structure under src.

Mr-Markus commented 5 years ago

I understand and it makes sense to me. I know that most JS projects have a src folder, but Microsoft in there corefx repository, too. So I also named it src.

But i will merge it, because I already thought about putting libraries projects into this path and codegenerator into tools or anything like that as you did in your PR. That is more clear I think

Thx :-)

Gallimathias commented 5 years ago

We can change that at any time if it is better for us otherwise.

I could imagine that we should separate the source code the topic documents in the repo overflow then it would be good to separate document and code more strictly for the sake of clarity