search

Mr-Markus / ZigbeeNet

A .NET Standard library for working with ZigBee
Eclipse Public License 1.0
131 stars 47 forks source link

Makes the properties of ZigBeeCommand and ZclCommand internal #60

Closed TheBlubb14 closed 5 years ago

TheBlubb14 commented 5 years ago

Makes the properties of ZigBeeCommand and ZclCommand internal so that ZigbeeNet users are not unnecessarily confused as to which properties to set in each command. So in the MoveToColorCommand only ColorX, ColorY and TransitionTime are available instead of ColorX, ColorY, TransitionTime, GenericCommand, CommandId, CommandDirection, SourceAddress and so on. Commands that need internal properties, such as NodeDescriptorRequest, must encapsulate these properties with their own property. In the example of NodeDescriptorRequest there is now the property Destination which refers to DestinationAddress.

Mr-Markus commented 5 years ago

Hi @TheBlubb14, I understand what you mean and it makes sense. But you have to change it in the Autocode generator project. Otherwise changes will be overwritten. I had not found any changes there in your commit. Have you noticed it? If you change it there it will be just a few lines of code :-)

After changing just execute the Autocode project and it will create new code within existing files

TheBlubb14 commented 5 years ago

Hi @Mr-Markus, No, I didn't notice. I adjusted the autocode generator. Have a nice vacation :slightly_smiling_face:

Mr-Markus commented 5 years ago

Thx :-)