search

Mr-Markus / ZigbeeNet

A .NET Standard library for working with ZigBee
Eclipse Public License 1.0
131 stars 47 forks source link

Issue comparing Nodes in ZigBeeNode.UpdateNode() #85

Closed spudwebb closed 4 years ago

spudwebb commented 4 years ago

The comparison of AssociatedDevices, BindingTable, Neighbors and Routes in UpdateNode() always return false because we use the default Object.Equals method which just compares the references.

We should compare the actual content of the list with something like this: http://msdn.microsoft.com/en-us/library/bb348567%28v=vs.110%29.aspx

Also why are they List whereas in the java project they are HashSet

spudwebb commented 4 years ago

in the pull request #87, I changed the List to HashSet and compared them suing SetEquals() method.

Mr-Markus commented 4 years ago

Thx. I merged the PR