Mr-Technician / BorderlessMinecraft

Application to run Minecraft as a borderless window.
GNU General Public License v3.0
121 stars 20 forks source link

Borderless Minecraft Crashes when MultiMC Instance Launched #31

Closed swishkin closed 2 years ago

swishkin commented 2 years ago

The app (1.3.1) closes within a few seconds of launching my 1.17.1 instance in MultiMC, if "Automatic Borderless" is selected. I'd like for Borderless Minecraft to work automatically, but returning to manual mode prevents these crashes and allows successful borderless usage.

Is there anything I can provide (log, etc) to help debugging this?

Mr-Technician commented 2 years ago

That's a strange bug... If it provided some sort of crash report I would like to see it. @swishkin

swishkin commented 2 years ago

It closed without warning or any log/report that I saw; is there somewhere it'd put something like that?

Mr-Technician commented 2 years ago

I get a popup like this if I manually throw an exception: image

Since you don't get one I'm wondering if an exception isn't actually being thrown, but I'm not sure why borderless minecraft would crash otherwise.

How does your MultiMC instance of Minecraft show up in the task manager?

swishkin commented 2 years ago

Yes, it shows up as shown below:

image

Mr-Technician commented 2 years ago

Can you expand the Java process? Sorry for all the steps, I should have asked for that before. 😅

swishkin commented 2 years ago

Here you go!

image

cornerkey commented 2 years ago

I Have exactly the same issue when automatic fullscreen is selected through multi mc

cornerkey commented 2 years ago

The path is different for multimc instances idk if that makes a difference

Mr-Technician commented 2 years ago

I'll need to install MultiMC and test with it so I can see what's going on...

I assume you don't get a crash report? @cornerkey

cornerkey commented 2 years ago

@Mr-Technician No i dont get a crash report it just straight up closes

cornerkey commented 2 years ago

it works if use normal launcher but i use multi mc because i speedrun and its easier to launch and maintain different instances

Mr-Technician commented 2 years ago

Ok, I will test with MultiMC if I get the chance. :)

cornerkey commented 2 years ago

ty u can ask me if u need assistance in any way

Mr-Technician commented 2 years ago

ty u can ask me if u need assistance in any way

If you're feeling adventurous you can download the source code, run borderless minecraft from there, and see if an error comes up. :)

That requires Visual Studio though.

Mr-Technician commented 2 years ago

I've tracked down the bug. MultiMC does something weird that causes Borderless Minecraft to detect a java process that no longer exists, which throws an exception. I've added code to prevent this but need to debug some other odd behavior with automatic borderless before releasing it.

Mr-Technician commented 2 years ago

The other auto borderless issues appear to be resolved. I will clean the changes up tomorrow and release an update to fix this issue. 🚀

cornerkey commented 2 years ago

Thank you so much you were extremely helpful and you responded so quick, im really impressed.

swishkin commented 2 years ago

I really appreciate you looking into this and debugging it! I've switched to GDLauncher, and while it doesn't crash, it seems like it doesn't automatically borderless either. :/