search

Mr-Technician / BorderlessMinecraft

Application to run Minecraft as a borderless window.
GNU General Public License v3.0
129 stars 20 forks source link

BorderlessMC automatic borderless not making windows borderless with MultiMC #34

Open cornerkey opened 2 years ago

cornerkey commented 2 years ago

The Latest release (v1.3.2 ) fixed the issue of BorderlessMC crashing on instance start from MultiMC if automatic borderless was enabled I've encountered another proble i.e : I have automaticborderless enabled but borderlessMC just doesnt make minecraft borderless when it starts it just stays windowed and i have to manually make it borderless. The reason i require automatic borderless is bc i am writing up a python script that open a complete catalogue of programs and borderlessmc are one of them

Mr-Technician commented 2 years ago

Oh no, I was positive I fixed this. 😭

Mr-Technician commented 2 years ago

In my limited testing it seems auto borderless is hit or miss with multiMC. This is probably related to the initial issue of how multiMC starts the java process and how that affects the process detection. I will need to investigate further.

Mr-Technician commented 2 years ago

@cornerkey could you do some more testing? Try restarting Borderless Minecraft and also try restarting Minecraft via MultiMC if auto borderless doesn't work the first time.

cornerkey commented 2 years ago

@Mr-Technician i've tried restarting both multiMC , minecraft and borderless . It affects nothing.

cornerkey commented 2 years ago

I think multiMC starts a instance of minecraft way differently than the normal launcher does because im writing a python script to start up multiple instances of minecraft through multiMC and it is possible to launch it with windows cmd terminal by "E:\MultiMC\MultiMC.exe -launch 1.16.1INST1" < this is an example. So im guessing its something to do with it creating a virtual space of some sort for minecraft to launch. I wish i knew C# so i could help u investigate lol. Btw i dont know if this is a valid conclusion ill do some research on my side but this is all just what i think and not fact

Mr-Technician commented 2 years ago

I think multiMC starts a instance of minecraft way differently than the normal launcher does

Yes it would seem so... That's what caused the crashing issue in the first place. :(

If you want to debug further and maybe hop into a video call you can join the Discord. https://discord.gg/gbR7qba6uv