search

Mr-X-GTA / YimMenu

YimMenu, a GTA V menu protecting against a wide ranges of the public crashes and improving the overall experience.
https://yim.gta.menu
GNU General Public License v2.0
81 stars 23 forks source link

[Improvement]: Translations are still pulled from the original YimMenu repo #15

Closed KernelFrog closed 1 month ago

KernelFrog commented 1 month ago

Which feature

Translations are currently dowloaded from the original YimMenu/Translations repo: https://raw.githubusercontent.com/YimMenu/Translations/master E.g. In https://github.com/Mr-X-GTA/YimMenu/blob/master/src/services/translation_service/translation_service.cpp

We should have our own Translations repo.

Reason

If original YimMenu is shutdown/wiped this fork will lose its translations.

Additional context

No response

Tessio commented 1 month ago

There is already a backup of the translations, however the link to the original repo is still being used, as it has not been deleted for the moment, so it makes no sense to bother doing something that still works, in due time if necessary a PR will be launched.

c: