search

Mr0grog / editorconfig-textmate

An EditorConfig plug-in for TextMate
Other
123 stars 8 forks source link

Update editorconfig core to v0.12.0 #16

Closed Mr0grog closed 9 years ago

Mr0grog commented 9 years ago

So… this stores libpcre directly in the repo, which seems somewhat non-ideal. However, the only other option I can think of seems kind of lame, too:

Detect, via script, what libpcre cmake finds for EditorConfig-Core and copy that in. (This is even more fugly since it finds libpcre.dylib instead of libpcre.a, which means you have to make a more complicated transform…)

If anybody watching this has clever ideas (paging @xuhdev), I'd be happy to hear them.

Mr0grog commented 9 years ago

Also, this fixes #13, #14.

xuhdev commented 9 years ago

It seems fine.. The editorconfig core version is also fixed any way.. Maybe the pcre library can also be used as a submodule, which has a cmake-based build system.

Mr0grog commented 9 years ago

Well, I'd rather not go through the pain of trying to get the build process for PCRE also working and properly set up in Xcode; it took me a while to get it right for EditorConfig-Core and I'm not sure there's much to gain from doing it for PCRE. I think I will probably merge this as-is for now.