Open Mr0grog opened 1 year ago
Hey, @Mr0grog! I created a PR for the 4th task: https://github.com/Mr0grog/google-docs-to-markdown/pull/43
I don't have a deep understanding of node, so would love a review if there is something very wrong with this and if there are points that can be improved, before investigating further the aspect you pointed out about rehype-dom-parse
and retype-parse
.
Thanks in advance!
I have the node side of this working here https://github.com/Mr0grog/google-docs-to-markdown/pull/84
Thanks! That’s super helpful. I left a bunch of comments on the various PRs you posted.
A couple folks have expressed interest in using this package as a library and making it available on NPM (see #40, #41). Getting there requires several smaller pieces of work:
[x] Move all reusable code into
lib/
and separate it from the code that is UI/webpage-centric. (#40][ ] Add changelog and tooling around proper semantic versioning.
[x] Have at least some basic tests for the library code. (#51)
[ ] Create separate entrypoints for browser and non-browser (e.g. Node.js) runtimes. For browsers, we use the
rehype-dom-parse
package to parse the HTML source of a GDocs document into a Rehype AST. That depends on browser built-ins that aren’t available in other runtimes, though! For non-browsers, we want to useretype-parse
instead.[ ] Determine if the package should be renamed (since it is converting GDocs-centric HTML, rather than an actual GDocs data structure).
[ ] (Maybe?) Add a basic CLI interface.
[ ] Publish v1.0.0!