search

MrAlaux / Nugget-Doom

Nugget Doom is a fork of Woof! with additional features.
GNU General Public License v2.0
60 stars 3 forks source link

Crashes when loading a save #55

Closed kutulhu closed 1 year ago

kutulhu commented 1 year ago

Hello! not sure how I can send you a log, basically I was playing Zeppelin Armada (DBP59) and I would get a crash to desktop whenever reloading a save. Settings were mostly defaults except 800p rendering resolution and vanilla complevel.

I did three playthroughs of this WAD, 2 in Nugget and 1 in dsda, dsda never crashed, but it had some other bugs.

This also happened with Auger;Zenith.

This is a Windows Event Log of the hang, it's always the same, I think.

Log Name: Application Source: Application Error Date: 7/25/2023 10:08:20 AM Event ID: 1000 Task Category: Application Crashing Events Level: Error Keywords:
User:
Computer:
Description: Faulting application name: nugget-doom.exe, version: 2.0.0.0, time stamp: 0x64b09223 Faulting module name: nugget-doom.dll, version: 0.0.0.0, time stamp: 0x64b0921f Exception code: 0xc0000005 Fault offset: 0x0000000000094c4c Faulting process id: 0x0x25F4 Faulting application start time: 0x0x1D9BEF8E831F12F Faulting application path: D:\Games\DOOM\Nugget Doom\nugget-doom.exe Faulting module path: D:\Games\DOOM\Nugget Doom\nugget-doom.dll Report Id: f6ae592b-3429-4f40-9b8d-d09aaa8900e5 Faulting package full name: Faulting package-relative application ID:

MrAlaux commented 1 year ago

Thanks for the log, but I must admit that I don't know what to do with it.

I'm actually playing through ZA myself, and it does sometimes crash when reloading saves, but I've no idea of what could be the cause. I'm inclined to believe that this issue is rooted in Woof, but it really could be anything.

Does it always crash for you when reloading saves?

MrAlaux commented 1 year ago

Potentially relevant: https://github.com/fabiangreffrath/woof/issues/1150.

kutulhu commented 1 year ago

Thanks for the log, but I must admit that I don't know what to do with it.

I'm actually playing through ZA myself, and it does sometimes crash when reloading saves, but I've no idea of what could be the cause. I'm inclined to believe that this issue is rooted in Woof, but it really could be anything.

Does it always crash for you when reloading saves?

Certainly not always. I had the most during the last level.

MrAlaux commented 1 year ago

Potentially relevant: fabiangreffrath#1150.

It looks like this report unintentionally reopened that issue in Woof, which just got a fix. If I were to make a temporary test branch applying that fix to Nugget, could you replay some map in either WAD and see if the crashes persist?

kutulhu commented 1 year ago

Potentially relevant: fabiangreffrath#1150.

It looks like this report unintentionally reopened that issue in Woof, which just got a fix. If I were to make a temporary test branch applying that fix to Nugget, could you replay some map in either WAD and see if the crashes persist?

Sure!

MrAlaux commented 1 year ago

If I were to make a temporary test branch applying that fix to Nugget, could you replay some map in either WAD and see if the crashes persist?

Sure!

Alright, builds are available here.

kutulhu commented 1 year ago

If I were to make a temporary test branch applying that fix to Nugget, could you replay some map in either WAD and see if the crashes persist?

Sure!

Alright, builds are available here.

Did quite a bit of testing and it seems to have solved the issue.

MrAlaux commented 1 year ago

Did quite a bit of testing and it seems to have solved the issue.

Good, I hope it stays like that. I'll merge the fix later alongside the rest of upstream changes, but feel free to stick to that patched build in the meanwhile.

If the crash reoccurs, please let me know. Thanks!