Allocate status bar buffer based on sbar height

[ceski-1]

Fixes https://github.com/MrAlaux/Nugget-Doom/issues/71

[ceski-1]

@MrAlaux When you update the changelog, please credit Fabian for the solution.

[MrAlaux]

@MrAlaux When you update the changelog, please credit Fabian for the solution.

Would you mind if I credit you too? You did make the PR after all.

[ceski-1]

Would you mind if I credit you too? You did make the PR after all.

Sure, no problem.

[MrAlaux]

The warnings are emitted every time the screen is restarted, I think that's unnecessary. Could you add something along the lines of static boolean firsttime to ST_loadGraphics() to only print them once? Woof is affected too, but maybe Fabian does want to keep the multiple warnings.

Unrelated: excuse me @fabiangreffrath, the following weird characters are printed alongside the warnings: I remember seeing some relevant commits regarding that output, but I don't remember the details and if this is expected. Mind the antique window style, that's actually Win7.

[ceski-1]

The warnings are emitted every time the screen is restarted, I think that's unnecessary.

I agree, they only show once now.

[MrAlaux]

Alright, looks good to me. Anything left you can think of?

[ceski-1]

I'm happy with this but maybe wait for the upstream PR in case there are more changes.

[fabiangreffrath]

Unrelated: excuse me @fabiangreffrath, the following weird characters are printed alongside the warnings:

This means that this code doesn't work on your system. @rfomin any ideas?

https://github.com/fabiangreffrath/woof/blob/54eb621036c0e5b9abe57fec8aad2eb3f3908367/src/i_printf.c#L63-L83

[rfomin]

Unrelated: excuse me @fabiangreffrath, the following weird characters are printed alongside the warnings:

This means that this code doesn't work on your system. @rfomin any ideas?

https://github.com/fabiangreffrath/woof/blob/54eb621036c0e5b9abe57fec8aad2eb3f3908367/src/i_printf.c#L63-L83

It seems ENABLE_VIRTUAL_TERMINAL_PROCESSING works only on Windows 10+. I will try to fix this.

[rfomin]

@MrAlaux could you please test this commit https://github.com/fabiangreffrath/woof/commit/3c546497117231910fccba0979a18640f4e64df3 ? Error messages should appear in the console without extra characters.

[MrAlaux]

@MrAlaux could you please test this commit fabiangreffrath@3c54649 ? Error messages should appear in the console without extra characters.

Yep, seems to be working. See:

Before


After


[fabiangreffrath]

Thank you @rfomin!