Darkmode and gif optimization.

MrBartusek / gif-picker-react

Tenor GIF Picker component for React ⚛️

http://dokurno.dev/gif-picker-react/

MIT License

38 stars 12 forks source link

Darkmode and gif optimization. #12

Closed 0xM4m4n closed 1 year ago

0xM4m4n commented 1 year ago

Added the option to pass minimal or basic for media filter. Originally when browsing the picker the gifs were loading at full resolution. My client browser was loading anywhere from 500kb to 40MB per gif. Using tnygif as the query param instead reduces these values by 100-1000x.
Added an option to pass light / darkmode theme
~Bump to minor version 1.1.0 since this includes some non patch related upgrades. None of these changes should be breaking changes.~
Tested on storybook locally no issues.

MrBartusek commented 1 year ago

For the next time. This PR should be actually split into two or three separate ones. One for dark theme, one for tinygif/preview stuff and a third one for other misc changes. That way it would be easier to review.

0xM4m4n commented 1 year ago

For the next time. This PR should be actually split into two or three separate ones. One for dark theme, one for tinygif/preview stuff and a third one for other misc changes. That way it would be easier to review.

Agreed, apologies for all in one, was working on it late last night and got carried away

MrBartusek commented 1 year ago

Close hover is too light

MrBartusek commented 1 year ago

Loading placeholders are white

MrBartusek commented 1 year ago

Thank you!

0xM4m4n commented 1 year ago

Sorry missed those last few comments the other day. Thanks for making the changes and merging!