search

MrBartusek / gif-picker-react

Tenor GIF Picker component for React ⚛️
http://dokurno.dev/gif-picker-react/
MIT License
37 stars 10 forks source link

Search input localization #29

Open nickmaio opened 4 months ago

nickmaio commented 4 months ago

Is there a chance to be able to replace search input placeholder text with a localized version?

PS. Awesome package, thanks!

MrBartusek commented 4 months ago

I think it would actually be a great idea to implement a localization system overall since things like #28 will just make a need for more strings.

However I am not sure what would be a best practice here for implementing, I don't see many packages ship localisation.

nickmaio commented 4 months ago

Localization on the Tenor level is pretty much 100% when you set both props country and locale correctly, no further work is required here. All that's hardcoded in 'en-EN' right now is the search input placeholder. A tiny inconvenience that may rather be resolved by exposing a single prop.