MrBrax / LiveStreamDVR

An automatic livestream recorder
MIT License
330 stars 25 forks source link

Fix pipenv detection by updating dockerfile to install pipenv #422

Closed btalanski closed 1 year ago

btalanski commented 1 year ago

By adding pip3 install --user pipenv to Dockerfile, the UI is now able to detect pipenv version properly.

I noticed this after seeing the following error msg in the logs:

helper <ERROR> pipenv binary not found at: /usr/local/bin/pipenv

MrBrax commented 1 year ago

good idea, but unfortunately the server itself doesn't use pipenv and i never figured out (or really spent much time figuring out) how to do it, so it would only really bloat the image until it's fully implemented

btalanski commented 1 year ago

Should it be removed or maybe commented out for now ?

MrBrax commented 1 year ago

yeah i just haven't had the energy to work on this for a while, and the pipenv thing has been neglected since release

btalanski commented 1 year ago

I'll update the PR later.