MrBrax / LiveStreamDVR

An automatic livestream recorder
MIT License
349 stars 25 forks source link

Fix YouTube playlist insert #487

Closed timschneeb closed 10 months ago

timschneeb commented 10 months ago

Using the Docker develop image, I noticed that the YouTube playlist insert API call failed with the message Playlist id not specified. It's fixed after adding a 'this.' before the playlist_id variable.

2024-01-04T19:42:52.886Z | YouTubeExporter.export <success> Video uploaded: wuM-TsF7XXX
2024-01-04T19:42:52.887Z | YouTubeExporter.addToPlaylist <info> Adding wuM-TsF7XXX to playlist...
2024-01-04T19:42:52.887Z | YouTubeExporter.addToPlaylist <info> Found playlist PLvNNyUh4Ovo0Zk9PLjUsFMPYoSAcXXXX for channel XYZ
2024-01-04T19:42:53.223Z | YouTubeExporter.addToPlaylist <error> Could not add video to playlist: Playlist id not specified.
2024-01-04T19:42:53.223Z | YouTubeExporter.export <error> Could not add video to playlist: Playlist id not specified.
2024-01-04T19:42:53.224Z | automator.onEndDownload <error> Export error: Playlist id not specified.
MrBrax commented 10 months ago

this isn't really how the logic is supposed to flow, i think i made an error in the playlist id empty check on line 399, but where you've changed code it's supposed to be a "fallback" if the automatic settings are not configured. it needs a bit of a rethink from me

timschneeb commented 10 months ago

oh yeah, I see. I didn't further look into the reason why the function parameter is empty in the first place