search

MrBuddyCasino / ESP32_Alexa

An Alexa Smart Speaker project for the ESP32.
Mozilla Public License 2.0
265 stars 72 forks source link

support for v1053 mp3 encoder #32

Closed gyroing closed 6 years ago

gyroing commented 6 years ago

i wonder,is it possible to add support to vs1053 mp encoder ? like KaraDio32

MrBuddyCasino commented 6 years ago

Why would want that?

gyroing commented 6 years ago

for 2 purpose : 1- not having the Dac module and better quality and decreasing code for implementing decoding and increasing memory, as wll as vs1053 has a licensed for mp3 decoding.

MrBuddyCasino commented 6 years ago

Makes no sense to me.

  1. I2S already provides full quality at a cheaper cost than the VS1053
  2. MP3 decoders never have required a license
  3. MP3 patents have all run out anyway
gyroing commented 6 years ago

Thanks for reply , and i forget vs1053 included internal mic also , so it is possible to combine audio (in-out),

chegewara commented 6 years ago

i can say that esp32 simple-alexa board designed by @kodera2t is working pretty awesome with this library and is not very expensive (around $26 or 29)