search

MrBuddyCasino / ESP32_MP3_Decoder

A internet radio and bluetooth speaker project for the Espressif ESP32
774 stars 182 forks source link

Changed 'i2s_push_sample' and 'i2s_write_bytes' to 'i2s_write'. #59

Closed koos96 closed 6 years ago

koos96 commented 6 years ago

This PR should fix #55.

I'm fairly new to the ESP32 and contributing on Github, so please let me know if I should change or improve something.

Did you set the 'ticks_to_wait' variable to 0 on purpose, or is it okay to change it to 'max_wait' like the other i2s_write calls?

https://github.com/MrBuddyCasino/ESP32_MP3_Decoder/blob/580bbb94a4d0c0729af50d942941a616f925f93a/components/audio_renderer/audio_renderer.c#L133

MDHMatt commented 6 years ago

i can confirm that this still works as expected and removes the depreciation messages.

MrBuddyCasino commented 6 years ago

Thanks for the PR! The ticks_to_wait was set to 0 for a reason, yet I don't remember it right now. If it turns out to be a problem we can reconsider.